Improving queue type on processor to avoid casting #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosGamero
commented
Nov 26, 2024
Comment on lines
-44
to
+51
| QueueType extends Queue<JobPayload, JobReturn> = Queue<JobPayload, JobReturn>, | ||
| QueueType extends Queue<JobPayload, JobReturn, string, JobPayload, JobReturn, string> = Queue< | ||
| JobPayload, | ||
| JobReturn, | ||
| string, | ||
| JobPayload, | ||
| JobReturn, | ||
| string | ||
| >, |
There was a problem hiding this comment.
As JobPayload is not defined at this stage, TS can't infer NameType
export declare class Queue<..., DefaultNameType extends string = string, ..., NameType extends string = ExtractNameType<DataTypeOrJob, DefaultNameType>> {
type ExtractNameType<DataTypeOrJob, Default extends string> = DataTypeOrJob extends Job<any, any, infer N> ? N : Default;
So trying to define it explicitly to help TS
CarlosGamero
requested review from
kibertoad,
dariacm,
ondrejsevcik and
a team
as code owners
|
I tested it locally by linking AP to this version of the library and looks like it is working with BullMqPro so I think it should be fine |
kibertoad
approved these changes
Dec 2, 2024
CarlosGamero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
major,minor,patchorskip-release